Skip to content
  • Muniza's avatar
    cookiecutter-event-application: Minor bug fixes · c9de5c4d
    Muniza authored and Gmodena's avatar Gmodena committed
    * fix(cookiecutter-event-app:tests): request appropriately scoped fixtures
    
    `tmp_path` is a function scoped fixture and cannot be requested by session scoped
    fixtures as their lifetimes would mismatch. This causes pytest to raise:
    
    ScopeMismatch: You tried to access the 'function' scoped fixture 'tmp_path' with a
    'session' scoped request object, involved factories
    conftest.py:24:  def fixture_sink_path(tmp_path)
    
    This is fixed by requesting `tmp_path_factory` instead, which is session scoped.
    
    * docs: fix cookiecutter template directory in readme example command
    
    The curent example command passes `cookiecutter-event-pipeline` instead of
    `cookiecutter-event-application` which causes cookiecutter to error out with:
    
    A valid repository for "git+https://gitlab.wikimedia.org/repos/data-engineering/eventutilities-python.git"
    could not be found in the following locations:
    ~/.cookiecutters/eventutilities-python/cookiecutter-event-pipeline
    c9de5c4d
Loading