Skip to content

requestctl: safeguard when deleting ACL ipblocks

Giuseppe Lavagetto requested to merge acl-delete into main

For some scopes, we implement ipblocks in varnish as ACLs, not netmapper files, so we could end up with an invalid configuration when deleting such objects, if there are uncommitted changes to actions.

So:

  • Add a configuration allowing to define the requestctl ipblock scopes that are implemented as ACLs
  • When deleting an ipblock in that group, check if there are uncommitted changes. This is made a new public method as it will be useful for hiddenparma too
  • If that's the case, throw an exception and refuse to delete the object.

Bug: T378435

Merge request reports