Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • B Buildkit
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Custom issue tracker
    • Custom issue tracker
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • repos
  • relengreleng
  • Buildkit
  • Merge requests
  • !27

buildctl: Provide --wait-for-ready option

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Dduvall requested to merge review/add-wait-for-ready-support-pr-3586 into wmf/v0.11 Feb 16, 2023
  • Overview 1
  • Commits 2
  • Pipelines 3
  • Changes 6

Added --wait-for-ready timeout to buildctl's global options. See below for behavior.

Implemented a WithWaitForReady client option method that blocks remote calls should the connection ever enter a transient failure state and waits up to the given duration until a connection is ready again before retrying the call. Note that if data has been written to the connection, retries are not attempted. See grpc.WaitForReady documentation for details.

Also note this option only applies to unary calls other than Solve as the timeout is applied to the context of the call and the latter is too likely to exceed a given timeout.

Edited Feb 16, 2023 by Dduvall
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: review/add-wait-for-ready-support-pr-3586