Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • E extensions
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Custom issue tracker
    • Custom issue tracker
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • repos
  • phabricator
  • extensions
  • Merge requests
  • !3

GitLabPatchesCustomField: limit searching to only the Tnnn form

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Brennen Bearnes requested to merge search-only-t-format into wmf/stable Mar 15, 2023
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 1

This follows on some discussion from T330792.

taavi:

I believe the Bug: #nnn was used to refer to Bugzilla in the past - how are you planning to avoid confusion with that?

brennen:

Or maybe we just shouldn't use the custom bug tracker integration to avoid confusion, remove the gitlab-phabricator matching for #nnn, and standardize on the Tnnn syntax, since that's what people are already used to. I'm not sure the integration adds all that much value.

xcollazo:

My vote is for standardizing on Tnnn, as that is what I expect as a Phabricator user. It also avoids your ambiguity issue.

I think I agree, and this also cuts in half the amount of search traffic hitting our GitLab instance every time a Phabricator task is viewed, which is probably not a bad idea.

Bug: T324149 Bug: T330792

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: search-only-t-format