VolkerE (fb684d32) at 01 Mar 15:02
Fix modern config
When using the modern config with Browserslist v4.23.0, I noticed that the list of browsers didn't include Chrome, Opera, and Edge. Collapsing the four "Last 3 years and…" queries into one fixes this problem (compare [0] with [1]).
When using the modern config with Browserslist v4.23.0, I noticed that the list of browsers didn't include Chrome, Opera, and Edge. Collapsing the four "Last 3 years and…" queries into one fixes this problem (compare [0] with [1]).
VolkerE (aa9f7e33) at 27 Feb 13:58
Merge branch 'project-add-mint-research' into 'master'
... and 2 more commits
Bug: T344471
Bug: T344471
There are two ** at the end of the URL hindering it from working.
It's already set in eslint-config-wikimedia, so we don't need it here.
Let's keep the review chain. It's better aligned to internal policy.
Raise basic Internet Explorer from 11+ to 12+ Is this a non-documented workaround? Or did you write another browser?
Previously, if the user selected a multi-word title from the autocomplete list like "Phillip K. Dick", they would be taken to a broken ResultsView that corresponded to the invalid URL of "Phillip_K. Dick".
The go() method on the StartView performs some basic title normalization, but the regex which replaced " " with "_" was lacking the /g flag. That flag has been added to ensure that all underscores are now replaced when the selected title is converted into a URL parameter.
In the future, we would ideally rely on the mw-title NPM package to parse titles and namespaces more correctly:
https://www.npmjs.com/package/mediawiki-title
Bug: T325983
Previously, if the user selected a multi-word title from the autocomplete list like "Phillip K. Dick", they would be taken to a broken ResultsView that corresponded to the invalid URL of "Phillip_K. Dick".
The go() method on the StartView performs some basic title normalization, but the regex which replaced " " with "_" was lacking the /g flag. That flag has been added to ensure that all underscores are now replaced when the selected title is converted into a URL parameter.
In the future, we would ideally rely on the mw-title NPM package to parse titles and namespaces more correctly:
https://www.npmjs.com/package/mediawiki-title
Bug: T325983
LGTM!