accessibility: Use CdxField wherever possible

Tacsipacsirequested to merge
tacsipacsi/lingua-libre:cdx-field into main

Using CdxField instead of custom solutions

  • increases consistency both within the application (various amounts of margin used to be used, now it’s the same everywhere) and with other Codex applications (for example, the Codex default is bold labels, while this application used to use normal-weight labels);
  • and improves accessibility by associating labels with their inputs.

Also migrate the error feedback in the external tools dialog to the CdxField error handling. (Note that this error handling is still far from being accessible: the popup closes before the error message would appear, so the user likely doesn’t ever see it...) For better compatibility with virtual keyboards, also specify input-type="url" on the URL field.

I considered migrating the error handling of the Wikimedia category popup as well, but it turned out the error message is always null (and I don’t even see what error could occur), so just remove it. Should it ever become used, it can be added back – preferably with the CdxField solution.

In the nearby dialog, the error message actually belongs to the button, not the entire field, so I’m not sure what to do with it; leave it as-is for now.

Merge request reports