1. 27 Oct, 2022 1 commit
  2. 21 Oct, 2022 2 commits
  3. 20 Oct, 2022 3 commits
  4. 19 Oct, 2022 6 commits
    • Ahmon Dancy's avatar
      .gitlab-ci.yml: Use kokkuri · 8df1d63c
      Ahmon Dancy authored
      Change-Id: Ib21826579f49b6b55aeb5e2b3d68429a132cafb4
      8df1d63c
    • Ahmon Dancy's avatar
      Merge branch 'master' into hacking · 4f023302
      Ahmon Dancy authored
      Change-Id: Ic4aedae9687586dac3aceba9edcd9f90dde20562
      4f023302
    • Jaime Nuche's avatar
      Release 4.27.1-1 · 6d428ca0
      Jaime Nuche authored and Ahmon Dancy's avatar Ahmon Dancy committed
      Change-Id: I7a055618da9d2a67d75b89aaa8706266711840ac
      6d428ca0
    • Jaime Nuche's avatar
      install-world: absolute path to requirements.txt · e8342135
      Jaime Nuche authored and Ahmon Dancy's avatar Ahmon Dancy committed
      When running install-world outside of a scap checkout, the pip install
      would fail to find the `requirements.txt`. Use an absolute path instead.
      
      Change-Id: Ieb78c750a5e4f04cc316634274a45a611ef3af02
      e8342135
    • Hashar's avatar
      install-world: tempdir must be owned by scap · bb3b4e81
      Hashar authored and Ahmon Dancy's avatar Ahmon Dancy committed
      Fix up installation when running as a normal user. The temporary
      directory used to hold the scap directory must be owned by scap, not by
      the user running the script. Else one has:
      
       deploy-1004$ scap install-world
       Scap version "4.27.0" will be installed on 3 host(s). Proceed? (y/n): y
       Installing scap version "4.27.0" for 3 hosts
       Installing version 4.27.0 locally
       HEAD is now at 84df53ec Release 4.27.0-1
       INFO: Tag "4.27.0" checked out
       ----
       mktemp: failed to create directory via template ‘/var/lib/scap/.scap-venv.XXXXXX’: Permission denied
       ----
       Switched to branch 'master'
       install-world failed:
         <CalledProcessError> Command [
          '/srv/deployment/scap/bin/install_local_version.sh',
          '-u', 'scap', '-t', '4.27.0', '/srv/deployment/scap']
         returned non-zero exit status 1.
      
      Change-Id: I48b1b0d53e3c7e77eeebfa59482e1cdf38d10a52
      bb3b4e81
    • Chad's avatar
      Drop pointless from __future__isms as pointless · 7f66ea96
      Chad authored and Ahmon Dancy's avatar Ahmon Dancy committed
      To quote the docs:
      """
      All historical features...are all redundant because they are always
      enabled, and only kept for backwards compatibility.
      """
      
      https://docs.python.org/3/reference/simple_stmts.html#future
      
      While we're here, drop a leftover from StringIO import StringIO too
      
      Change-Id: I71b522d59736a1aa47658481c278fc893a0a5df8
      7f66ea96
  5. 18 Oct, 2022 1 commit
  6. 14 Oct, 2022 15 commits
    • Ahmon Dancy's avatar
      Update .gitlab-ci.yml file · 779fd9bd
      Ahmon Dancy authored
      779fd9bd
    • Ahmon Dancy's avatar
      blubber.yaml: Decouple the *-build and *-test images · 4c42b96b
      Ahmon Dancy authored
      Build the *-build images separately from the *-test images.
      
      Change-Id: I9942b1df01653affd5c79b7ce49e05e0419dd8f8
      4c42b96b
    • Jeena Huneidi's avatar
      scap backport: refactor dependency checks · 94095a51
      Jeena Huneidi authored and Ahmon Dancy's avatar Ahmon Dancy committed
      * Does a more thorough check that cross repo dependencies are met
      * Allows option to merge non-production patches
      
      Perfomance improvements:
      * Caches git submodules for each branch
      * Moves dependency check to change validation step
      
      Change-Id: I41deeac2111cc5efbec320900f07ac85f6c6a699
      94095a51
    • Ahmon Dancy's avatar
      blubber.yaml: Decouple the *-build and *-test images · 713c5e67
      Ahmon Dancy authored
      Build the *-build images separately from the *-test images.
      
      Change-Id: I9942b1df01653affd5c79b7ce49e05e0419dd8f8
      713c5e67
    • Ahmon Dancy's avatar
      perform-release: Fix old version handling · 16766590
      Ahmon Dancy authored
      With the old code, LAST_TAG was not set globally by the time it was
      used at the end of the script.  I think this was because
      suggest_new_version is being called in a subshell.
      
      I moved the extraction of the old version tag from suggest_new_version
      and made the old version a parameter to it.
      
      Change-Id: Icdb69b14e8b89c40875e445b0befdc3864a3fe76
      16766590
    • Ahmon Dancy's avatar
      Release 4.27.0-1 · 38305415
      Ahmon Dancy authored
      Change-Id: Ida16ee76e74c2ae386101f8413de3a23abbb5db5
      38305415
    • Dduvall's avatar
      checks: Only validate checks for the current stage · 6ed7466c
      Dduvall authored and Ahmon Dancy's avatar Ahmon Dancy committed
      Refactored Check constructor to not perform validation, allowing the
      caller to filter check objects before validating.
      
      DeployLocal now only validates checks for the given stage and
      "before/after" event.
      
      Bug: T319472
      Change-Id: Ie7acd88b3dba2b2574fa4a4223e91a10ea2c336d
      6ed7466c
    • Ahmon Dancy's avatar
      Release 4.26.0-1 · 9f4d8a9b
      Ahmon Dancy authored
      Change-Id: I893323d8f157bce0825777d9e0cd8e23e85253c1
      9f4d8a9b
    • Dduvall's avatar
      scripts: Log (debug) registration of scripts · dbdf37b0
      Dduvall authored and Ahmon Dancy's avatar Ahmon Dancy committed
      Add debug-level logging of check scripts registration.
      
      Bug: T319472
      Change-Id: Icc2de8863fec2219058d90468b12ac339e37bcd6
      dbdf37b0
    • Hashar's avatar
      install-world: install only declared requirements · 6f265d1c
      Hashar authored and Ahmon Dancy's avatar Ahmon Dancy committed
      We have an exaustive list of requirements which is enforced by CI and
      test, this is the counterpart at installation time to ensure we do not
      install transitive dependencies (--no-deps).
      
      Bug: T316755
      Change-Id: I5342e0e46bdb5662785d6ffdf6c870440c5f82d3
      6f265d1c
    • Jeena Huneidi's avatar
      scap backport: check for already merged dependency · 6620cfcb
      Jeena Huneidi authored and Ahmon Dancy's avatar Ahmon Dancy committed
      Allows a backport to continue if the dependency has already been
      included in the branch to be merged.
      
      Change-Id: Id3ef665312b92fdae886d86e913fab5c69f73ca0
      6620cfcb
    • Hashar's avatar
      install-world: ensure a clear venv · 066cf507
      Hashar authored and Ahmon Dancy's avatar Ahmon Dancy committed
      When running `install_local_version.sh`, the installed requirements
      would pile up in the target virtualenv. Requirements that got removed
      from the `requirements.txt` file would still be present at the target
      destination.
      
      This replace the existing virtualenv with a fresh one installed from
      scratch. On installation failure, the old version is restored.
      
      Change-Id: Id404a1115c3029a21cb85172f5bc70c480b5831f
      066cf507
    • Ahmon Dancy's avatar
      config.py: Update default value for canary_dashboard_url · 55f6e36b
      Ahmon Dancy authored
      Set canary_dashboard_url to https://logstash.wikimedia.org, the value
      landed on in T291870.  The previous default stopped working long ago.
      
      Bug: T291870
      Change-Id: I8f06949381757ec511468f7f85dde5d2d2f0a2df
      55f6e36b
    • Hashar's avatar
      Add .editorconfig · b71dfd98
      Hashar authored and Ahmon Dancy's avatar Ahmon Dancy committed
      Introduce https://editorconfig.org/ configuration which lets one define
      the expected indentation to be used on files and has support for a wide
      range of editors.
      
      Nothing is enforced, my primary intent is to have my editor to default
      to space for indentation.
      
      Change-Id: Ifeeef586b33873fa4f165df8522a90677334bd90
      b71dfd98
    • Ahmon Dancy's avatar
      test-requirements.txt: Set flake8 to 5.0.4 · 4d6b92a1
      Ahmon Dancy authored
      Advance flake8 from 3.9.2 to 5.0.4 to avoid the following error during
      `make test-buster` that started happening recently:
      
      flake8 (coding style checks)
      
      Traceback (most recent call last):
        File "/opt/lib/python/site-packages/bin/flake8", line 8, in <module>
          sys.exit(main())
        File "/opt/lib/python/site-packages/flake8/main/cli.py", line 22, in main
          app.run(argv)
        File "/opt/lib/python/site-packages/flake8/main/application.py", line 363, in run
          self._run(argv)
        File "/opt/lib/python/site-packages/flake8/main/application.py", line 350, in _run
          self.initialize(argv)
        File "/opt/lib/python/site-packages/flake8/main/application.py", line 330, in initialize
          self.find_plugins(config_finder)
        File "/opt/lib/python/site-packages/flake8/main/application.py", line 153, in find_plugins
          self.check_plugins = plugin_manager.Checkers(local_plugins.extension)
        File "/opt/lib/python/site-packages/flake8/plugins/manager.py", line 357, in __init__
          self.namespace, local_plugins=local_plugins
        File "/opt/lib/python/site-packages/flake8/plugins/manager.py", line 238, in __init__
          self._load_entrypoint_plugins()
        File "/opt/lib/python/site-packages/flake8/plugins/manager.py", line 254, in _load_entrypoint_plugins
          eps = importlib_metadata.entry_points().get(self.namespace, ())
      AttributeError: 'EntryPoints' object has no attribute 'get'
      
      Change-Id: I78d5d19261e49f65c6e798bc93ab385d98022c7e
      4d6b92a1
  7. 12 Oct, 2022 4 commits
  8. 11 Oct, 2022 6 commits
  9. 07 Oct, 2022 2 commits