Change-Id: Ib21826579f49b6b55aeb5e2b3d68429a132cafb4

Change-Id: Ic4aedae9687586dac3aceba9edcd9f90dde20562

Jaime Nuche authored Oct 19, 2022 and Ahmon Dancy committed Oct 19, 2022

Change-Id: I7a055618da9d2a67d75b89aaa8706266711840ac

Jaime Nuche authored Oct 19, 2022 and Ahmon Dancy committed Oct 19, 2022

When running install-world outside of a scap checkout, the pip install
would fail to find the `requirements.txt`. Use an absolute path instead.

Change-Id: Ieb78c750a5e4f04cc316634274a45a611ef3af02

Hashar authored Oct 19, 2022 and Ahmon Dancy committed Oct 19, 2022

Fix up installation when running as a normal user. The temporary
directory used to hold the scap directory must be owned by scap, not by
the user running the script. Else one has:

 deploy-1004$ scap install-world
 Scap version "4.27.0" will be installed on 3 host(s). Proceed? (y/n): y
 Installing scap version "4.27.0" for 3 hosts
 Installing version 4.27.0 locally
 HEAD is now at 84df53ec Release 4.27.0-1
 INFO: Tag "4.27.0" checked out
 ----
 mktemp: failed to create directory via template ‘/var/lib/scap/.scap-venv.XXXXXX’: Permission denied
 ----
 Switched to branch 'master'
 install-world failed:
   <CalledProcessError> Command [
    '/srv/deployment/scap/bin/install_local_version.sh',
    '-u', 'scap', '-t', '4.27.0', '/srv/deployment/scap']
   returned non-zero exit status 1.

Change-Id: I48b1b0d53e3c7e77eeebfa59482e1cdf38d10a52

Chad authored Oct 15, 2022 and Ahmon Dancy committed Oct 19, 2022

To quote the docs:
"""
All historical features...are all redundant because they are always
enabled, and only kept for backwards compatibility.
"""

https://docs.python.org/3/reference/simple_stmts.html#future

While we're here, drop a leftover from StringIO import StringIO too

Change-Id: I71b522d59736a1aa47658481c278fc893a0a5df8

Change-Id: Id8dc779d0ee870e55143d1ed5ef84505584ba25e

Build the *-build images separately from the *-test images.

Change-Id: I9942b1df01653affd5c79b7ce49e05e0419dd8f8

Jeena Huneidi authored Oct 05, 2022 and Ahmon Dancy committed Oct 14, 2022

* Does a more thorough check that cross repo dependencies are met
* Allows option to merge non-production patches

Perfomance improvements:
* Caches git submodules for each branch
* Moves dependency check to change validation step

Change-Id: I41deeac2111cc5efbec320900f07ac85f6c6a699

Build the *-build images separately from the *-test images.

Change-Id: I9942b1df01653affd5c79b7ce49e05e0419dd8f8

With the old code, LAST_TAG was not set globally by the time it was
used at the end of the script.  I think this was because
suggest_new_version is being called in a subshell.

I moved the extraction of the old version tag from suggest_new_version
and made the old version a parameter to it.

Change-Id: Icdb69b14e8b89c40875e445b0befdc3864a3fe76

Change-Id: Ida16ee76e74c2ae386101f8413de3a23abbb5db5

Dduvall authored Oct 05, 2022 and Ahmon Dancy committed Oct 14, 2022

Refactored Check constructor to not perform validation, allowing the
caller to filter check objects before validating.

DeployLocal now only validates checks for the given stage and
"before/after" event.

Bug: T319472
Change-Id: Ie7acd88b3dba2b2574fa4a4223e91a10ea2c336d

Change-Id: I893323d8f157bce0825777d9e0cd8e23e85253c1

Dduvall authored Oct 05, 2022 and Ahmon Dancy committed Oct 14, 2022

Add debug-level logging of check scripts registration.

Bug: T319472
Change-Id: Icc2de8863fec2219058d90468b12ac339e37bcd6

Hashar authored Sep 28, 2022 and Ahmon Dancy committed Oct 14, 2022

We have an exaustive list of requirements which is enforced by CI and
test, this is the counterpart at installation time to ensure we do not
install transitive dependencies (--no-deps).

Bug: T316755
Change-Id: I5342e0e46bdb5662785d6ffdf6c870440c5f82d3

Jeena Huneidi authored Oct 03, 2022 and Ahmon Dancy committed Oct 14, 2022

Allows a backport to continue if the dependency has already been
included in the branch to be merged.

Change-Id: Id3ef665312b92fdae886d86e913fab5c69f73ca0

Hashar authored Sep 28, 2022 and Ahmon Dancy committed Oct 14, 2022

When running `install_local_version.sh`, the installed requirements
would pile up in the target virtualenv. Requirements that got removed
from the `requirements.txt` file would still be present at the target
destination.

This replace the existing virtualenv with a fresh one installed from
scratch. On installation failure, the old version is restored.

Change-Id: Id404a1115c3029a21cb85172f5bc70c480b5831f

Set canary_dashboard_url to https://logstash.wikimedia.org, the value
landed on in T291870.  The previous default stopped working long ago.

Bug: T291870
Change-Id: I8f06949381757ec511468f7f85dde5d2d2f0a2df

Hashar authored Oct 03, 2022 and Ahmon Dancy committed Oct 14, 2022

Introduce https://editorconfig.org/ configuration which lets one define
the expected indentation to be used on files and has support for a wide
range of editors.

Nothing is enforced, my primary intent is to have my editor to default
to space for indentation.

Change-Id: Ifeeef586b33873fa4f165df8522a90677334bd90

Advance flake8 from 3.9.2 to 5.0.4 to avoid the following error during
`make test-buster` that started happening recently:

flake8 (coding style checks)

Traceback (most recent call last):
  File "/opt/lib/python/site-packages/bin/flake8", line 8, in <module>
    sys.exit(main())
  File "/opt/lib/python/site-packages/flake8/main/cli.py", line 22, in main
    app.run(argv)
  File "/opt/lib/python/site-packages/flake8/main/application.py", line 363, in run
    self._run(argv)
  File "/opt/lib/python/site-packages/flake8/main/application.py", line 350, in _run
    self.initialize(argv)
  File "/opt/lib/python/site-packages/flake8/main/application.py", line 330, in initialize
    self.find_plugins(config_finder)
  File "/opt/lib/python/site-packages/flake8/main/application.py", line 153, in find_plugins
    self.check_plugins = plugin_manager.Checkers(local_plugins.extension)
  File "/opt/lib/python/site-packages/flake8/plugins/manager.py", line 357, in __init__
    self.namespace, local_plugins=local_plugins
  File "/opt/lib/python/site-packages/flake8/plugins/manager.py", line 238, in __init__
    self._load_entrypoint_plugins()
  File "/opt/lib/python/site-packages/flake8/plugins/manager.py", line 254, in _load_entrypoint_plugins
    eps = importlib_metadata.entry_points().get(self.namespace, ())
AttributeError: 'EntryPoints' object has no attribute 'get'

Change-Id: I78d5d19261e49f65c6e798bc93ab385d98022c7e