Skip to content

Never use $refed schema examples

Snwachukwu requested to merge github/fork/ottomata/master into master

Created by: ottomata

We never want to use an $ref'd schema's examples field. However, if the $ref'd schema does have examples the incoming schema doesn't, then by default the schemaResolver will pull in the $ref'ed schema's examples, there will be only one examples candidate, and mergeAllOf will end up just choosing the $ref'd schema's examples without any conflict to merge.

To avoid this, check if the incoming schema examples field is defined. Since we ALWAYS and ONLY want to keep examples if they are from the incoming schema, use this do determine if we should delete the examples field from the schema after merging $refs.

Bug: T270134

Merge request reports