David Caro (5e1e3720) at 28 Mar 17:14
api: add some logs about the routes registered on start
... and 1 more commit
David Caro (d5163c95) at 28 Mar 17:07
api: add some logs about the routes registered on start
... and 1 more commit
hmm, I had time to think about this and yep, we should keep it, makes the api clearer to some extent (otherwise we would have the oneOff
without discriminator
property, that's always confusing).
David Caro (3997ed86) at 28 Mar 15:47
api: add some logs about the routes registered on start
... and 3 more commits
@raymond-ndibe can you rebase this on top of !70 ?
And can you help reviewing that too? we should try to avoid piling up so many MRs and make sure before creating new ones that we have reviewed all the ones that are pending reviews.
Raymond Ndibe (5463b976) at 28 Mar 00:10
[jobs-api] support services in jobs
Raymond Ndibe (4251edef) at 28 Mar 00:09
[jobs-api] support services in jobs
Raymond Ndibe (504b70c7) at 28 Mar 00:07
[jobs-api] support services in jobs
Raymond Ndibe (ede85241) at 27 Mar 23:59
[jobs-api] support services in jobs
Raymond Ndibe (0ce3e9a9) at 27 Mar 23:51
[jobs-api] support services in jobs
Raymond Ndibe (a1707224) at 27 Mar 23:16
[jobs-api] support services in jobs
Raymond Ndibe (f6dd06d3) at 27 Mar 22:44
[jobs-api] support services in jobs
Bug: T348758 Signed-off-by: Ndibe Raymond Olisaemeka rolisaemeka-ctr@wikimedia.org
Raymond Ndibe (77e06c2d) at 27 Mar 22:38
[jobs-api] support services in jobs
yes, yes, I'm just pointing out the question there that blocks this MR
Though the question of not really needing the type
property at all still stands. I'm being a bit careful with this as it's in the API, and it's hard to undo API changes later (when we open to the users).
I don't think the comment on jobs-cli is at odds with having type
. we can figure out the type based on which argument was set in the frontend and then format it to the type the backend expects
See the comment in jobs-cli!16
This means though that in the code we have to differentiate between health checks by "the shape" of them, not by the type they say they are.
(as the openapi def differentiates by the shape, not the 'type' value)
We don't need the type here anymore