[jobs-api] move custom validations out of api models (!150) · Merge requests · repos / cloud / toolforge / Jobs API · GitLab

How to register an account on GitLab. Due to spam, new accounts are locked until approved by an admin or the approver bot. Your GitLab account gets automatically approved within one hour if you are a member of Trusted Contributors in Gerrit, or a member of the Trusted-Contributors group in Phabricator and linked your Developer account ("LDAP") to your Phabricator account. If none of these apply, file an unlock request to expedite access. Only if you are WMF staff: Create your GitLab account, have "Wmf" group membership in IDM, link your Developer account ("LDAP") to your Phabricator account, and get automatically approved.

Support: mw:GitLab, how to host a project on GitLab, #wikimedia-gitlab on libera.chat, #GitLab on Phabricator.

Raymond Ndibe requested to merge move_most_custom_validations_out_of_api_models into main Mar 19, 2025

remove cap from replica value from openapi spec (seems like an oversight)
remove most custom pydantic validations and move them to both tjf/core/job.py and tjf/runtimes/k8s/jobs.py (depending on where they are most suitable for)
refactor from_job ( some things there are legacy of the previous job comparision feature. Now job comparisons are done on the k8s side some of these things are no longer needed here )

Depends-on: jobs-cli!96
Bug: T389118
Signed-off-by: raymond-ndibe rndibe@wikimedia.org

Edited Apr 14, 2025 by Raymond Ndibe