Kosta Harlan (0573db65) at 14 Mar 13:57
Bug: T360067
Kosta Harlan (035b9a20) at 13 Mar 20:16
make-release: Start branching IPReputation
Kosta Harlan (c6b63f29) at 12 Mar 14:07
Merge branch 'main-I1c722ed3a8af28912c035a9fbf86a5596d966548' into ...
... and 1 more commit
IPv6 IPs can be requested in various states of concatenation but
ipoid looks for IPs on exact matches. If a user submits an IPv6
IP and it's formatted differently than ipoid expects, the IP won't
be returned. The IP should be found and it should also be returned
as the user passed it through instead of ipoid's formatting.
Bug: T354758
LGTM. Very minor comment which is that we could move ip-utils.js
into a lib
directory, to make it more clear that it's an external library.
Kosta Harlan (3fc04e78) at 01 Mar 13:42
Merge branch 'normalize-ip' into 'main'
... and 1 more commit
Also add a test for the IP normalization.
might be nice to test this branch, but we could do that in a follow-up.
Kosta Harlan (2745316b) at 29 Feb 08:44
Merge branch 'remove-maint-script' into 'main'
... and 1 more commit
Bug: T354758
This has now run (log) so we can merge and deploy this.
Does this service have a use-case outside of the WMF / do we support non-WMF installs?
No, it does not have a supported use-case outside WMF, and we don't support usages elsewhere.
If so, perhaps we can leave the maintenance script but remove it from main.sh once we are happy that it has fixed things on the WMF install.
That sounds fine to me as well.
Kosta Harlan (520aec9b) at 21 Feb 10:45
@stran, what do you think?
Right, sorry I missed that. Should we change this to just <
check and remove the [[ $yesterday == "$today" ]];
check?
I am not sure if that was intentional.
I think what you describe (we should try to fix the error on the follow-up run on the same day) makes sense.
Kosta Harlan (bbd7a098) at 14 Feb 17:14
main: Use "yesterday" as the current import date
Kosta Harlan (95b64e49) at 14 Feb 17:10
main: Use "yesterday" as the current import date