Serialize OSM element when logging

wmfmaps/changeset/verifier.py

@@ -15,6 +15,18 @@ class ElementHandler:
         self.failfast = failfast
         self.inconsistencies = []
 
+    def serialize(self, change):
+        tags = {}
+        for tag in change.tags:
+            tags[tag.k] = tag.v
+
+        return {
+            "id": change.id,
+            "changeset": change.changeset,
+            "version": change.version,
+            "tags": tags,
+        }
+
     def exists(self, table, osm_id):
         query = f"SELECT * FROM {table} WHERE osm_id = {osm_id}"
         cursor = self.conn.cursor()
@@ -29,7 +41,7 @@ class ElementHandler:
                         f"Element with id:{change.id} shouldn't exist"
                     )
                 self.inconsistencies.append(
-                    {"type": "should be deleted", "id": change.id}
+                    {"type": "should be deleted", "element": self.serialize(change)}
                 )
                 break
 
@@ -45,7 +57,9 @@ class ElementHandler:
                 raise InconsistentChangeException(
                     f"Element with id:{change.id} should exist"
                 )
-            self.inconsistencies.append({"type": "should exist", "id": change.id})
+            self.inconsistencies.append(
+                {"type": "should exist", "element": self.serialize(change)}
+            )
 
     def log_inconsistencies(self):
         for elem in self.inconsistencies: