Reverts the revert of !1 and initializes $other_assignee
to avoid blowing up when there aren't multiple assignees on the workboard.
Bug: T329974 Bug: T332234
Dylsss (c71603cc) at 21 Mar 22:38
Indent other_assignee_fields
Same error on line 152 when there are no tasks on the workboard.
$other_assignee_fields = array();
Reverts the revert of !1 and initializes $other_assignee
to avoid blowing up when there aren't multiple assignees on the workboard.
Bug: T329974 Bug: T332234
Dylsss (240d720b) at 14 Mar 15:51
Dylsss (240d720b) at 14 Mar 01:30
Fix spelling
Dylsss (2da1d491) at 14 Mar 01:20
fix
It was an extra query per every task. Above change should reduce to just one query on the workboard for the custom field. However it does make the change slightly more complicated.
Dylsss (eb283115) at 14 Mar 01:13
Avoid N+1 queries
I assume the field key is defined here: https://phabricator.wikimedia.org/config/edit/maniphest.custom-field-definitions/. Which I can't access.
Project task cards now query the other assignee field and adds the user handle to the card. Also modified PHUIObjectItemView so that the handle icons also contribute to the phui-oi-with-n-actions so that the handle icons don't overlap with the card content.
I've used the field key std:maniphest:wm.otherassignee
for testing, but I don't actually know what the field key is on the Phabricator deployment, so it needs be changed to the correct field key before merging.
Bug: T329974
Dylsss (f04d9468) at 18 Feb 05:33
Add support for showing other assignee on project board.
Dylsss (145d44c1) at 18 Feb 05:15
Add support for showing other assignee on project board.
Dylsss (6ba172b6) at 18 Feb 04:10