Added tests for API SPEC JSON except for Device analytics. I think it has not implemented.
ALL TESTS should pass now.
BPirkle (4cb8d843) at 05 Dec 15:11
Merge branch 'T349993_api_spec_json' into 'main'
... and 1 more commit
BPirkle (9ba259f4) at 02 Oct 15:05
Merge branch 'T346255_update_tests' into 'main'
... and 1 more commit
Added data validation points for the pageviews service endpoints
BPirkle (02e9c7bc) at 24 Aug 21:31
Merge branch 'T344304_add_data_tests_page_analytics' into 'main'
... and 1 more commit
No, that's not it at all.
What I'm saying is that, as written, the tests can lie. They can say they're testing one thing, when they're really testing another. That's confusing and misleading.
I'm saying that if a test says it tests "US" and "2021", it should test "US" and "2021", not whatever some other file tells it to test.
Right - so if I made a local.ini file with country = DE
and year = 2023
under \[pageviews_top_per_country\]
and ran the tests as behave -D env=local
, then the test would output "request is made to pageviews_top_per_country for year 2021 using US", but it would have actually run the test against DE and 2023, not US and 2021 like it claimed?
One thought/question on conventions.
To be sure I understand, this tests "2021" and "US", because those are the defaults in utilities/prod.ini under "pageviews_top_per_country".
However, nothing in this actual test guarantees that it will actually test "US" and "2021", right? And if the test suite were invoked with a different env that used a different .ini file with different defaults for those fields, then test would claim in the output that it had tested "US" and "2021", but it actually wouldn't have?
I'm tempted to say that if the test claims to test for specific values, then it should have those values actually coded into the test, so that it is guaranteed to do what it says that it does. What do you think?
BPirkle (b6eea635) at 31 Jul 08:28
Tests for Media Analytics aggregate endpoint update to Device analytics endpoint update to Media analytics top endpoint
BPirkle (d0251c14) at 27 Jul 23:40
Merge branch 'T337114_media_analytics_aggregate' into 'main'
... and 1 more commit
Tests for Media Analytics aggregate endpoint update to Device analytics endpoint update to Media analytics top endpoint
BPirkle (b6eea635) at 26 Jul 18:22
Additional encoding fixes for encoded forward slashes, dashes, and ...
BPirkle (74305e3c) at 24 Jul 22:44
Merge branch 'T337119_media_analytics_top' into 'main'
... and 1 more commit
Media analytics top endpoint tests
Media analytics top endpoint tests
LGTM, executes find when run locally against existing production AQS
BPirkle (3c50b159) at 21 Jul 20:37
Add encoding fix to all scripts, manually fix affected csv files